Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly introduced test 125_shared_boolean.t requires threads::shared 1.21 #170

Closed
ribasushi opened this issue Aug 30, 2020 · 4 comments
Closed
Assignees
Labels

Comments

@ribasushi
Copy link

As per subject - the test needs to check for minimum version of t::s, and skip_all if not available.

Failure without this:

Undefined subroutine &main::shared_clone called at t/125_shared_boolean.t line 14.
# Looks like your test exited with 255 before it could output anything.
[06:52:22] t/125_shared_boolean.t ..... 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 8/8 subtests 

Thanks!

@rurban rurban self-assigned this Aug 30, 2020
@rurban rurban added the bug label Aug 30, 2020
@karenetheridge
Copy link
Contributor

This affects all perls at or before 5.10.0.

@rurban
Copy link
Owner

rurban commented Aug 31, 2020

This affects all perls at or before 5.10.0

Only with its pristine libs, never updated. Which nobody should do. Otherwise I would have detected it in my smoke testing with all Perl versions.

@karenetheridge
Copy link
Contributor

Ah indeed, I had not realized (having not ever really used threads much) that threads::shared is dual-life rather than core only.

rurban added a commit that referenced this issue Sep 4, 2020
@rurban
Copy link
Owner

rurban commented Sep 5, 2020

Fixed with 4.22/4.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants