New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only skip hash keys sorting for actually tied hashes #42

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dur-randir
Contributor

dur-randir commented Nov 23, 2015

As of version 2.25, JSON::XS announced that it won't sort tied hashes under the 'canonical' option. But it's implementation covered too broad range of magic - SvRMAGICAL is set for any magic other then mg_get/mg_set upon cast.

It was discovered in the garu/Data-Printer#75 issue that the core module Hash::Util::FieldHash can easily produce hashes that won't be sorted by JSON::XS::encode_json despite being not tie'd.

@rurban

This comment has been minimized.

rurban commented on ae1541b Nov 24, 2015

Looks good. But I broke master, need to fix that first

@rurban rurban self-assigned this Nov 25, 2015

@rurban rurban added the bug label Nov 25, 2015

@rurban rurban added this to the Next Release milestone Nov 25, 2015

@rurban

This comment has been minimized.

Owner

rurban commented Nov 25, 2015

@rurban

This comment has been minimized.

Owner

rurban commented Nov 26, 2015

Rebased into release 3.0201

@rurban rurban closed this Nov 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment