Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set path correctly for PERL_CORE #11

Merged
merged 1 commit into from Apr 12, 2020
Merged

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Apr 12, 2020

One of the major changes introduced in perl-5.28 in 2018 was a security fix which caused directory . to no longer be automatically included in @INC. Prior to that production release, we had to make certain workarounds in an important component of the Perl 5 testing infrastructure, t/TEST, to accommodate three CPAN distributions which are shipped with the Perl 5 core distribution.

The Filter distribution was one of those three. We would like to be able to remove the workaround from t/TEST. To that end, I am submitting this pull request which includes revisions to the BEGIN block in two files and which I have tested successfully both in core and in a git checkout.

If these changes are satisfactory, we would appreciate a new CPAN release of Filter so that we can then synch it into Perl 5 blead.

Thank you very much.
Jim Keenan

@jkeenan
Copy link
Contributor Author

jkeenan commented Apr 12, 2020

@rurban rurban self-assigned this Apr 12, 2020
@rurban
Copy link
Owner

rurban commented Apr 12, 2020

The description is wrong. Can you change it to "push Cwd to @INC in 2 tests" or something like that? There is no path fixed.
And I'll check if Cwd is really a good idea. Normally you just need to add . to @INC.

Accommodate constraints in PERL_CORE.
@jkeenan
Copy link
Contributor Author

jkeenan commented Apr 12, 2020 via email

@rurban rurban merged commit b308b9b into rurban:master Apr 12, 2020
@jkeenan jkeenan deleted the no-dot-20200411 branch April 12, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants