New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8_heavy can be reloaded during run time #364

Closed
atoomic opened this Issue Mar 23, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@atoomic
Collaborator

atoomic commented Mar 23, 2016

Difficult to provide a single one liner here for now, but if during compilation we load utf8_heavy.pl, like in PMOP::Save, then if during runtime we lazy load a module which requires utf8_heavy.pl this will result in a warning like

Subroutine _loose_name redefined at /usr/local/cpanel/3rdparty/perl/522/lib64/perl5/5.22.1/utf8_heavy.pl line 16.

This shows that we reload utf8_heavy whereas we should not.
After investigation this is coming from the fact that we save utf8 before utf8_heavy.
Simply fixing the order in which we walk the packages fixes it.

Potentially same problem with bytes_heavy.pl

atoomic added a commit to atoomic/perl-compiler that referenced this issue Mar 23, 2016

Fix utf8_heavy warning "Subroutine _loose_name redefined" - GH rurban…
…#364

Save utf8 and bytes last (before +/-) to be triggered
after loading (utf8|bytes)_heavy.pl in order to avoid
to load utf8_heavy.pl a second time during run time.

atoomic added a commit to atoomic/perl-compiler that referenced this issue Mar 23, 2016

Fix utf8_heavy warning "Subroutine _loose_name redefined" - GH rurban…
…#364

Save utf8 and bytes last (before +/-) to be triggered
after loading (utf8|bytes)_heavy.pl in order to avoid
to load utf8_heavy.pl a second time during run time.

rurban added a commit that referenced this issue Mar 23, 2016

Merge pull request #365 from atoomic/devel/gh364
Fix utf8_heavy warning "Subroutine _loose_name redefined" - GH #364
@rurban

This comment has been minimized.

Show comment
Hide comment
@rurban

rurban Mar 23, 2016

Owner

Thanks for the fix

Owner

rurban commented Mar 23, 2016

Thanks for the fix

@rurban rurban closed this Mar 23, 2016

rurban pushed a commit that referenced this issue May 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment