Please sign in to comment.
perl.h can include embed.h in the same location on all operating syst…
…ems. Commit 22c35a8 (October 1988) added a #include "embed.h" later in perl.h for when building with PERL_OBJECT defined. Commit d18c611 (November 1988) added an effectively duplicate #include for all WIN32. Commit 0cb9638 (June 1999) corrected the made the earlier #include in perl.h also conditional on !PERL_OBJECT (in addition to the !PERL_FOR_X2P added by 22c35a8), but it wasn't until commit d18c611 (November 1999) that this changed this to !WIN32, and embed.h was included exactly once by perl.h (as a2p never actually includes perl.h). Commit acfe0ab (August 2001) removed the PERL_OBJECT code from perl.h, reducing the duplication somewhat, but commit 96e176b (October 2001) created analogous special case duplication for VMS, and commit 27da23d (April 2005) for Symbian. Commit eb8433b (March 2006) then neatly put the same #ifndef PERL_MAD code after all 4 locations that included embed.h and commit b3f24c0 (April 2006) made the same correction in all 4 places. But, the daft part of all this is that there was no reason why Win32 was special - every other operating system can build perl with embed.h included later in perl.h Hence the earlier 3 locations can be eliminated, and the was-just-Win32 location made unconditional. Which saves some lines of code. But fewer lines than are in this commit message.
- Loading branch information...