Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a race in t/gh29-segv.t #35

Merged
merged 1 commit into from May 15, 2019

Conversation

Projects
None yet
2 participants
@ppisar
Copy link
Contributor

commented May 15, 2019

If the a parent process was too slow, a child process could print
"ok 2" before the parent printed "ok 1". That resulted into unordered
tests and was reported as an error.

This patch eliminites the race by synchronizing on the child
termination by calling waitpid(). Nevertheless it's necessary to
collect child's statuses to prevent from creating zombies.

#34

Avoid a race in t/gh29-segv.t
If the a parent process was too slow, a child process could print
"ok 2" before the parent printed "ok 1". That resulted into unordered
tests and was reported as an error.

This patch eliminites the race by synchronizing on the child
termination by calling waitpid(). Nevertheless it's necessary to
collect child's statuses to prevent from creating zombies.

#34

@rurban rurban self-requested a review May 15, 2019

@rurban rurban self-assigned this May 15, 2019

@rurban rurban added the bug label May 15, 2019

@rurban

rurban approved these changes May 15, 2019

@rurban rurban merged commit 2a91112 into rurban:master May 15, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@rurban

This comment has been minimized.

Copy link
Owner

commented May 15, 2019

Thanks a lot. There were 2 minor bugs, which I fixed up in the next commit. Released as 0.16

rurban added a commit that referenced this pull request May 15, 2019

Release 0.16
and fixup PR #35. need a space after not, and
dont rely on $?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.