Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time to migrate to Python 3! #3

Closed
rusefillc opened this issue Jan 14, 2022 · 5 comments
Closed

Time to migrate to Python 3! #3

rusefillc opened this issue Jan 14, 2022 · 5 comments

Comments

@rusefillc
Copy link

This repo still uses 2.7 version of Python

We need to pick migration attempts from the internet and combine with our functional fixes

@rusefillc
Copy link
Author

Kind of depends #4

@rusefillc
Copy link
Author

See also provideyourown#8

@rusefillc
Copy link
Author

Extra info:

there are too many gerbmerge forks. There is a fork with python3 but two problem with it

  1. that other fork does not have our fixes, so potentially one can PR all needed fixed into https://github.com/jnicolson/gerbmerge

  2. overall I am failing to even start https://github.com/jnicolson/gerbmerge see Is this fork trying to be compatible or has unique configuration approach? jnicolson/gerbmerge#10

It could be that the way to go is really to migrate our https://github.com/rusefi/gerbmerge fork to Python 3 as is since that's the safest way to make sure we have all the fixes/changes we need

@rusefillc
Copy link
Author

we have manual validation tests in https://github.com/rusefi/gerbmerge/tree/rusefi-tests

See also jnicolson#9

@andreika-git
Copy link
Collaborator

andreika-git@f78db83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants