From c7c443ea24a1000284970420b5ec0df23966f9ca Mon Sep 17 00:00:00 2001 From: rusefillc Date: Tue, 9 Aug 2022 13:26:11 -0400 Subject: [PATCH] https://github.com/rusefi/hellen154hyundai/issues/57 --- firmware/controllers/engine_cycle/map_averaging.cpp | 2 ++ firmware/controllers/system/efi_gpio.cpp | 4 +++- firmware/integration/rusefi_config.txt | 2 +- firmware/tunerstudio/rusefi.input | 1 + .../shared_io/src/main/java/com/rusefi/rusEFIVersion.java | 2 +- .../main/java/com/rusefi/ui/engine/EngineSnifferPanel.java | 1 + 6 files changed, 9 insertions(+), 3 deletions(-) diff --git a/firmware/controllers/engine_cycle/map_averaging.cpp b/firmware/controllers/engine_cycle/map_averaging.cpp index 8e6335e31f3..5a2e10c50c8 100644 --- a/firmware/controllers/engine_cycle/map_averaging.cpp +++ b/firmware/controllers/engine_cycle/map_averaging.cpp @@ -36,6 +36,8 @@ /** * this instance does not have a real physical pin - it's only used for engine sniffer + * + * todo: we can kind of add real physical pin just for a very narrow case of troubleshooting but only if we ever need it :) */ static NamedOutputPin mapAveragingPin("map"); diff --git a/firmware/controllers/system/efi_gpio.cpp b/firmware/controllers/system/efi_gpio.cpp index 7488af0a514..d9fba64086a 100644 --- a/firmware/controllers/system/efi_gpio.cpp +++ b/firmware/controllers/system/efi_gpio.cpp @@ -323,7 +323,9 @@ void NamedOutputPin::setHigh() { setValue(true); #if EFI_ENGINE_SNIFFER - addEngineSnifferEvent(getShortName(), PROTOCOL_ES_UP); + if (!engineConfiguration->engineSnifferFocusOnInputs) { + addEngineSnifferEvent(getShortName(), PROTOCOL_ES_UP); + } #endif /* EFI_ENGINE_SNIFFER */ } diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index f7aff95d587..1c26b8cb712 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -1036,7 +1036,7 @@ bit launchSparkCutEnable;+This is the Cut Mode normally used bit boardUseD4PullDown,"With Pull Down","With Pull Up" bit boardUseD5PullDown,"With Pull Down","With Pull Up" bit verboseIsoTp -bit unused444 +bit engineSnifferFocusOnInputs bit launchActivateInverted bit twoStroke,"Two Stroke","Four Stroke" bit skippedWheelOnCam,"On camshaft","On crankshaft";+Where is your primary skipped wheel located? diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input index 595a7f7b530..94ab47d649f 100644 --- a/firmware/tunerstudio/rusefi.input +++ b/firmware/tunerstudio/rusefi.input @@ -2025,6 +2025,7 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@\x00\x31\x00\x00" field = "Print verbose VVT sync details to console",verboseVVTDecoding field = "Print verbose trigger sync to console", verboseTriggerSynchDetails field = "Do not print messages in case of sync error", silentTriggerError + field = "Focus on inputs in engine sniffer", engineSnifferFocusOnInputs field = "Enable noise filtering", useNoiselessTriggerDecoder, {trigger_type == @@trigger_type_e_TT_TOOTHED_WHEEL_60_2@@ || trigger_type == @@trigger_type_e_TT_TOOTHED_WHEEL_36_1@@} dialog = triggerInputs, "Trigger Inputs" diff --git a/java_console/shared_io/src/main/java/com/rusefi/rusEFIVersion.java b/java_console/shared_io/src/main/java/com/rusefi/rusEFIVersion.java index 0e1887dac0a..f8e5fe7f30d 100644 --- a/java_console/shared_io/src/main/java/com/rusefi/rusEFIVersion.java +++ b/java_console/shared_io/src/main/java/com/rusefi/rusEFIVersion.java @@ -6,7 +6,7 @@ import java.util.concurrent.atomic.AtomicReference; public class rusEFIVersion { - public static final int CONSOLE_VERSION = 20220808; + public static final int CONSOLE_VERSION = 20220809; public static AtomicReference firmwareVersion = new AtomicReference<>("N/A"); public static long classBuildTimeMillis() { diff --git a/java_console/ui/src/main/java/com/rusefi/ui/engine/EngineSnifferPanel.java b/java_console/ui/src/main/java/com/rusefi/ui/engine/EngineSnifferPanel.java index fb8858f6c74..9dd7e521ca9 100644 --- a/java_console/ui/src/main/java/com/rusefi/ui/engine/EngineSnifferPanel.java +++ b/java_console/ui/src/main/java/com/rusefi/ui/engine/EngineSnifferPanel.java @@ -130,6 +130,7 @@ public void actionPerformed(ActionEvent e) { lowerButtons.add(new ConfigField(uiContext, Fields.GLOBALTRIGGERANGLEOFFSET, "Trigger Offset").getContent()); lowerButtons.add(new BitConfigField(uiContext, Fields.VERBOSETRIGGERSYNCHDETAILS, "Verbose trigger Sync").getContent()); lowerButtons.add(new BitConfigField(uiContext, Fields.VERBOSEVVTDECODING, "Verbose VVT Sync").getContent()); + lowerButtons.add(new BitConfigField(uiContext, Fields.ENGINESNIFFERFOCUSONINPUTS, "Focus On Inputs").getContent()); lowerButtons.add(new ConfigField(uiContext, Fields.ENGINECHARTSIZE, "Engine Sniffer size").getContent()); lowerButtons.add(new ConfigField(uiContext, Fields.ENGINESNIFFERRPMTHRESHOLD, "RPM threshold").getContent()); bottomPanel.add(lowerButtons, BorderLayout.NORTH);