Skip to content

Greg Rushton
rushtong

rushtong deleted branch gr-organizing at broadinstitute/consent-data-use
May 27, 2016
rushtong deleted branch master at broadinstitute/consent-data-use
May 27, 2016
May 27, 2016
@rushtong
May 27, 2016
@rushtong
Generic info updates.
1 commit with 33 additions and 30 deletions
May 27, 2016
@rushtong
Generic info updates.
1 commit with 33 additions and 30 deletions
May 27, 2016
May 27, 2016
May 26, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

I originally had this as a separate div, but that generates a full paragraph break which is much more than what I want and interferes with the meth…

May 26, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

':terminal' is not actually in use - I have it here purely for completeness.

May 26, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

The counts I'm showing here are the same as those defined in Rawls (see https://github.com/broadinstitute/rawls/blob/e6be332405bfa36c35f935d7ea613e…

May 26, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

Will implement that piece - great catch.

May 25, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

@davidangb Here's a thought: if this is going to ping the FireCloud back end (orch/rawls) every minute, it's possible that this endpoint will be …

May 25, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

You can test the error case by changing the queue endpoint url to something non-existent and see that show up in the Submissions line.

May 25, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

@davidangb, @MattPutnam - So, without the br tag, the status text and the user name butt up against each other in an ugly way, which is why I had t…

May 25, 2016
@rushtong
May 25, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

Yeah, I'm looking at re-formatting it.

May 25, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

I think I like Submissions: 504 Gateway Timeout best, or some variant of that. It's just very un-informative and not terribly user-friendly.

May 25, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

See Matt's feedback - will implement something along those lines.

May 25, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

👍

May 25, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

I struggled with that decision. There isn't really space for a full error, and I'm not sure what to display.

May 25, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

Sweet - that saves a lot of boilerplate.

May 25, 2016
@rushtong
  • @rushtong 935178e
    Minor re-org and fix missing closing paren.
May 24, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

To be honest, I'm not a fan of trying to squeeze different displays into the same layout just because we're using similar data. The two areas have …

May 24, 2016
@rushtong
May 24, 2016
rushtong commented on pull request broadinstitute/firecloud-ui#445
@rushtong

Terminal isn't currently in use in the UI, but is a category of statuses defined in Rawls. See https://github.com/broadinstitute/rawls/blob/e6be332…

May 24, 2016
@rushtong
Add a global status line for submissions in queue and active.
1 commit with 45 additions and 6 deletions
May 24, 2016
May 24, 2016
rushtong commented on pull request broadinstitute/rawls#434
@rushtong

Code looks good, tests pass. When running locally, I see a lot of [ERROR] [12:46:24.110] [rawls-akka.actor.default-dispatcher-16] o.b.d.r.j.Workfl…

May 17, 2016
rushtong commented on pull request broadinstitute/rawls#427
@rushtong

👍 Code looks good. There are tests that look at some of the other statuses. Do you want to add tests for these new ones?

May 11, 2016
rushtong commented on pull request broadinstitute/rawls#417
@rushtong

👍 - back to you @jmthibault79

Something went wrong with that request. Please try again.