Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nsync + test #1169

Merged
merged 3 commits into from Nov 10, 2017

Conversation

Projects
None yet
2 participants
@headupinclouds
Copy link
Contributor

commented Nov 6, 2017

Note:

  • TODO: replace include_directories() -> target_include_directories(), etc
  • OSX build has numerous deprecated function warnings
note: 'OSAtomicCompareAndSwap32Barrier' has been explicitly marked deprecated here
bool    OSAtomicCompareAndSwap32Barrier( int32_t __oldValue, int32_t __newValue, volatile int32_t *__theValue );

#1155

  • has hunter-packages/nsync
add nsync + test
Note:
* TODO: replace include_directories() -> target_include_directories(), etc
* OSX build has numerous deprecated function warnings
```
note: 'OSAtomicCompareAndSwap32Barrier' has been explicitly marked deprecated here
bool    OSAtomicCompareAndSwap32Barrier( int32_t __oldValue, int32_t __newValue, volatile int32_t *__theValue );
```

@headupinclouds headupinclouds referenced this pull request Nov 6, 2017

Open

Add Tensorflow #667

VERSION
1.14-p0
URL
"https://github.com/headupinclouds/nsync/archive/v1.14-p0.tar.gz"

This comment has been minimized.

This comment has been minimized.

Copy link
@headupinclouds

headupinclouds Nov 10, 2017

Author Contributor

Moved

@ruslo

ruslo approved these changes Nov 10, 2017

VERSION
1.14-p0
URL
"https://github.com/hunter-packages/nsync/archive/v1.14-p0.tar.gz"

This comment has been minimized.

This comment has been minimized.

Copy link
@headupinclouds

headupinclouds Nov 10, 2017

Author Contributor

Ouch. Thanks. Done. Test == SUCCESS

@ruslo

ruslo approved these changes Nov 10, 2017

@headupinclouds

This comment has been minimized.

Copy link
Contributor Author

commented Nov 10, 2017

  • vs-14-2015 is working, all others fail
  • NDK toolchains are failing due to:
/home/travis/build/ingenue/hunter/_testing/Hunter/_Base/9e18f06/97b2613/b5d6ba7/Build/nsync/Source/testing/array.c:15:10: fatal error: 'platform.h' file not found
#include "platform.h"
         ^~~~~~~~~~~~

There is no ANDROID branch in the CMakeLists.txt

https://github.com/hunter-packages/nsync/blob/93815892dddafe9146a5f7e7042281d59d0f4323/CMakeLists.txt#L32-L118

but such platform specific customizations do exist in the BAZEL build:

https://github.com/google/nsync/blob/93815892dddafe9146a5f7e7042281d59d0f4323/BUILD#L309-L316

CMake needs equivalents of the bazel platform specific branching + includes shown here:

NSYNC_OPTS_GENERIC = select({
    # Select the CPU architecture include directory.
    # This select() has no real effect in the C++11 build, but satisfies a
    # #include that would otherwise need a #if.
    ":gcc_linux_x86_64_1": ["-I" + pkg_path_name() + "/platform/x86_64"],
    ":gcc_linux_x86_64_2": ["-I" + pkg_path_name() + "/platform/x86_64"],
    ":gcc_linux_aarch64": ["-I" + pkg_path_name() + "/platform/aarch64"],
    ":gcc_linux_ppc64": ["-I" + pkg_path_name() + "/platform/ppc64"],
    ":gcc_linux_s390x": ["-I" + pkg_path_name() + "/platform/s390x"],
    ":clang_macos_x86_64": ["-I" + pkg_path_name() + "/platform/x86_64"],
    ":ios_x86_64": ["-I" + pkg_path_name() + "/platform/x86_64"],
    ":android_x86_32": ["-I" + pkg_path_name() + "/platform/x86_32"],
    ":android_x86_64": ["-I" + pkg_path_name() + "/platform/x86_64"],
    ":android_armeabi": ["-I" + pkg_path_name() + "/platform/arm"],
    ":android_arm": ["-I" + pkg_path_name() + "/platform/arm"],
    ":android_arm64": ["-I" + pkg_path_name() + "/platform/aarch64"],
    ":msvc_windows_x86_64": ["-I" + pkg_path_name() + "/platform/x86_64"],
}) + [
    "-I" + pkg_path_name() + "/public",
    "-I" + pkg_path_name() + "/internal",
    "-I" + pkg_path_name() + "/platform/posix",
] + select({
    ":msvc_windows_x86_64": [
    ],
    "//conditions:default": [
        "-D_POSIX_C_SOURCE=200809L",
        "-pthread",
    ],
})

In CMake + Android builds we have: ANDROID_ARCH

  • armv7-a: “ARMv7-A (armv7-a)”
  • armv7-a-hard: “ARMv7-A, hard-float ABI (armv7-a)”
  • arm64-v8a: “ARMv8-A, 64bit (arm64-v8a)”
  • x86: “x86 (x86)”
  • x86_64: “x86_64 (x86_64)”
@ruslo

This comment has been minimized.

Copy link
Owner

commented Nov 10, 2017

I will exclude everything that is not working for now. Later we can apply fixes.

@headupinclouds

This comment has been minimized.

Copy link
Contributor Author

commented Nov 10, 2017

Ok. I've added some initial Android patches in a PR for discussion here hunter-packages/nsync#1

@ruslo ruslo merged commit 7727cae into ruslo:master Nov 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@headupinclouds headupinclouds referenced this pull request Nov 10, 2017

Closed

add nsync #1155

@ruslo

This comment has been minimized.

Copy link
Owner

commented Nov 11, 2017

@headupinclouds headupinclouds deleted the elucideye:pr.nsync branch Jan 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.