Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for maintainers (join us!) #1496

Closed
matthewkmayer opened this issue Sep 6, 2019 · 15 comments
Closed

Looking for maintainers (join us!) #1496

matthewkmayer opened this issue Sep 6, 2019 · 15 comments
Labels

Comments

@matthewkmayer
Copy link
Member

@matthewkmayer matthewkmayer commented Sep 6, 2019

Interested in helping develop Rusoto? Want to do more than submitting PRs?

We're looking for maintainers to help!

Let me know if you'd like to help. My email address is in the Cargo.toml file. There's only one Matthew in there, should be easy to find. 😄

I can help with mentoring to get your environment up and running and help share the knowledge of the systems that may not be captured in documentation. To ensure I'm able to help those who ask for mentoring, I'll be limiting the number of people I'm mentoring at a time.

To be super clear, I'm not looking to leave the project. I would like another set of hands and eyes to keep things moving.

onboarding thoughts

I'd love for interested people to contribute a few PRs to demonstrate ability to solve our GitHub issues. Once that's done, please email me for a conversation and we can discuss what's expected: reviewing PRs, creating and closing issues, releasing new versions of Rusoto, etc... I'd like some kind of commitment for time but I'm not looking for a contract. Just a thoughtful "yes, I can spend some time each week on Rusoto." I don't want to scare anyone off. 😄

maintainer requirements

Rusoto heavily relies on its integration test suite to ensure correctness. Running these requires an AWS account and will incur charges when running them. I don't think I've ever run up more than a one dollar ($1.00) bill in a month of running the tests, but as they grow, the cost to run them may go up. Usually I see less than 10 cents ($0.10) a month of charges due to integration tests.

@pkoch

This comment has been minimized.

Copy link

@pkoch pkoch commented Sep 6, 2019

👋 Hello there!

I've been following the rust book and doing some exercism, but I've been finding it a lackluster way to get into the lang. Would you be up for fostering a Rust noob help you here? I'm kinda afraid to make a strong commitment that I won't be able to follow up on, bit I can tell you that I'm committed to learn Rust.

Do you think this can be productive?

@matthewkmayer

This comment has been minimized.

Copy link
Member Author

@matthewkmayer matthewkmayer commented Sep 7, 2019

We all start somewhere! Rusoto was my first Rust project beyond Hello, World. 😆

There are some tasks that are a bit easier to start with than others, such as #1402 and #1401 .

I'm sure there are other parts of Rusoto that need fixing up that aren't too complicated, but haven't had an issue made for them yet. Someone, possibly me, should go about making issues for those.

To answer the question: productive right from the start? Not many people can do that with a big codebase new to them. After some practice and addressing smaller issues? Most definitely! 👍

@softprops

This comment has been minimized.

Copy link
Contributor

@softprops softprops commented Sep 7, 2019

Other areas that can have surprising impact on the project don't actually involve deep rust knowledge.

Contributor documentation plays a huge role in the projects success. There were some sharp corners around the core workflow for updating and testing generated code when I first started. Some of those corners were made smoother for others by updating the contributing docs for the next folks. I feel like there's a lot of room for opportunity there.

If you've ever worked on ci infrastructure, rusotos size provides some interesting challenges. I think help in this area would also be helpful.

You'll sometimes find "how do I do x" GitHub issues. That's a key indicator the docs could use some improvement, not just to the rust docs but to the book as well.

Creating getting started guides and blog posts are also helpful ways to contribute to a project.

@matthewkmayer

This comment has been minimized.

Copy link
Member Author

@matthewkmayer matthewkmayer commented Sep 7, 2019

Lots of good points there, @softprops ! I'm thinking splitting some issues into various types could help contributors get started and have some become maintainers:

• docs, including rusoto.org pages
• sharp edges like massive documentation pages with entire service on it (split into trait, impl, types?)
• bugs seen when talking to AWS
• updates to dependencies
• more info on how we generate code and how to fix service code

Hopefully this can help direct newcomers.

@softprops

This comment has been minimized.

Copy link
Contributor

@softprops softprops commented Sep 8, 2019

That sounds like an awesome idea!

@matthewkmayer

This comment has been minimized.

@matthewkmayer

This comment has been minimized.

Copy link
Member Author

@matthewkmayer matthewkmayer commented Sep 27, 2019

Thank you to all the folks who have reached out and those who have made PRs! ❤️

This week I had conversations with various people at AWS. There may be opportunities for continued support in various avenues from folks at AWS as well as the continued support from the community.

I'm looking forward to the many ways we can keep this project thriving. 👍

@simplytunde

This comment has been minimized.

Copy link

@simplytunde simplytunde commented Sep 27, 2019

@matthewkmayer Rust noob checking. I will love to contribute in anyway I can to the project and a mentor will greatly help with that process.

@matthewkmayer

This comment has been minimized.

Copy link
Member Author

@matthewkmayer matthewkmayer commented Oct 3, 2019

I overestimated my capacity to offer mentoring. 😿

What I can do is review small PRs. Little changes are easier to review and can be a mentoring process as well. 👍

The best way to help is to dig in to an issue, ask questions if you're not sure about something, and make a small pull request with the fix.

In this project, small can be relative: a few lines of changes in our codegen may touch every service, but that's unavoidable. 😄

@matthewkmayer

This comment has been minimized.

Copy link
Member Author

@matthewkmayer matthewkmayer commented Oct 15, 2019

A big welcome to @iliana our newest maintaner! 🎉

@matthewkmayer

This comment has been minimized.

Copy link
Member Author

@matthewkmayer matthewkmayer commented Oct 23, 2019

Welcome @itsHabib as another new maintainer! 🎉

@softprops

This comment has been minimized.

Copy link
Contributor

@softprops softprops commented Oct 24, 2019

I've known been a side car contributor for a while but could I get added to https://github.com/orgs/rusoto/people?

@matthewkmayer

This comment has been minimized.

Copy link
Member Author

@matthewkmayer matthewkmayer commented Oct 27, 2019

@softprops Done! 😄

@matthewkmayer

This comment has been minimized.

Copy link
Member Author

@matthewkmayer matthewkmayer commented Oct 29, 2019

I think this issue is ready to close: we've picked up three new maintainers and have at least one more pending. With more active maintainers, there will be more coordination and onboarding efforts required of me, so let's cap it for now and revisit if needed.

Thoughts? 😄

@matthewkmayer

This comment has been minimized.

Copy link
Member Author

@matthewkmayer matthewkmayer commented Nov 1, 2019

Thanks everyone!

If I haven't responded to an email you've sent or a comment here it's because I missed it - please send a reminder to me. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.