Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upLooking for maintainers (join us!) #1496
Comments
This comment has been minimized.
This comment has been minimized.
|
I've been following the rust book and doing some exercism, but I've been finding it a lackluster way to get into the lang. Would you be up for fostering a Rust noob help you here? I'm kinda afraid to make a strong commitment that I won't be able to follow up on, bit I can tell you that I'm committed to learn Rust. Do you think this can be productive? |
This comment has been minimized.
This comment has been minimized.
|
We all start somewhere! Rusoto was my first Rust project beyond There are some tasks that are a bit easier to start with than others, such as #1402 and #1401 . I'm sure there are other parts of Rusoto that need fixing up that aren't too complicated, but haven't had an issue made for them yet. Someone, possibly me, should go about making issues for those. To answer the question: productive right from the start? Not many people can do that with a big codebase new to them. After some practice and addressing smaller issues? Most definitely! |
This comment has been minimized.
This comment has been minimized.
|
Other areas that can have surprising impact on the project don't actually involve deep rust knowledge. Contributor documentation plays a huge role in the projects success. There were some sharp corners around the core workflow for updating and testing generated code when I first started. Some of those corners were made smoother for others by updating the contributing docs for the next folks. I feel like there's a lot of room for opportunity there. If you've ever worked on ci infrastructure, rusotos size provides some interesting challenges. I think help in this area would also be helpful. You'll sometimes find "how do I do x" GitHub issues. That's a key indicator the docs could use some improvement, not just to the rust docs but to the book as well. Creating getting started guides and blog posts are also helpful ways to contribute to a project. |
This comment has been minimized.
This comment has been minimized.
|
Lots of good points there, @softprops ! I'm thinking splitting some issues into various types could help contributors get started and have some become maintainers: • docs, including rusoto.org pages Hopefully this can help direct newcomers. |
This comment has been minimized.
This comment has been minimized.
|
That sounds like an awesome idea! |
This comment has been minimized.
This comment has been minimized.
|
My blog posts on how Rusoto code generation works may help people get started: https://matthewkmayer.github.io/blag/public/post/rusoto-codegen/ https://matthewkmayer.github.io/blag/public/post/rusoto-codegen-part-two/ https://matthewkmayer.github.io/blag/public/post/rusoto-codegen-part-three/ |
This comment has been minimized.
This comment has been minimized.
|
Thank you to all the folks who have reached out and those who have made PRs! This week I had conversations with various people at AWS. There may be opportunities for continued support in various avenues from folks at AWS as well as the continued support from the community. I'm looking forward to the many ways we can keep this project thriving. |
This comment has been minimized.
This comment has been minimized.
|
@matthewkmayer Rust noob checking. I will love to contribute in anyway I can to the project and a mentor will greatly help with that process. |
This comment has been minimized.
This comment has been minimized.
|
I overestimated my capacity to offer mentoring. What I can do is review small PRs. Little changes are easier to review and can be a mentoring process as well. The best way to help is to dig in to an issue, ask questions if you're not sure about something, and make a small pull request with the fix. In this project, small can be relative: a few lines of changes in our codegen may touch every service, but that's unavoidable. |
This comment has been minimized.
This comment has been minimized.
|
A big welcome to @iliana our newest maintaner! |
This comment has been minimized.
This comment has been minimized.
|
Welcome @itsHabib as another new maintainer! |
This comment has been minimized.
This comment has been minimized.
|
I've known been a side car contributor for a while but could I get added to https://github.com/orgs/rusoto/people? |
This comment has been minimized.
This comment has been minimized.
|
@softprops Done! |
This comment has been minimized.
This comment has been minimized.
|
I think this issue is ready to close: we've picked up three new maintainers and have at least one more pending. With more active maintainers, there will be more coordination and onboarding efforts required of me, so let's cap it for now and revisit if needed. Thoughts? |
This comment has been minimized.
This comment has been minimized.
|
Thanks everyone! If I haven't responded to an email you've sent or a comment here it's because I missed it - please send a reminder to me. |
Interested in helping develop Rusoto? Want to do more than submitting PRs?
We're looking for maintainers to help!
Let me know if you'd like to help. My email address is in the Cargo.toml file. There's only one Matthew in there, should be easy to find.😄
I can help with mentoring to get your environment up and running and help share the knowledge of the systems that may not be captured in documentation. To ensure I'm able to help those who ask for mentoring, I'll be limiting the number of people I'm mentoring at a time.
To be super clear, I'm not looking to leave the project. I would like another set of hands and eyes to keep things moving.
onboarding thoughts
I'd love for interested people to contribute a few PRs to demonstrate ability to solve our GitHub issues. Once that's done, please email me for a conversation and we can discuss what's expected: reviewing PRs, creating and closing issues, releasing new versions of Rusoto, etc... I'd like some kind of commitment for time but I'm not looking for a contract. Just a thoughtful "yes, I can spend some time each week on Rusoto." I don't want to scare anyone off.😄
maintainer requirements
Rusoto heavily relies on its integration test suite to ensure correctness. Running these requires an AWS account and will incur charges when running them. I don't think I've ever run up more than a one dollar ($1.00) bill in a month of running the tests, but as they grow, the cost to run them may go up. Usually I see less than 10 cents ($0.10) a month of charges due to integration tests.