Join GitHub today
Integrate async fork #867
@Arcnor and I are currently spending our 20% time at work with Rust, and as part of this we took last week to fork rusoto and convert it to an async API based on futures/tokio.
Following #604 and #714, I would love to work together with you to merge these changes back into this project. Especially since the changes are quite far-reaching, continuing to rebase will be a painful process for me.
The code currently lives here. It fully compiles, and the protocol tests are successful. I have had trouble getting the integration tests to run, which is why I'd be keen to leverage the CI set up in this repo to do it.
The extend of the changes is as follows:
The story for synchronous use-cases is covered by a
There's a few minor things left to do (documentation mostly) from my side, but I'd like to try and get the ball rolling already if possible.
Also note that the credentials provider is still a blocking API, I'd prefer to get this "mostly async" state upstreamed first, and then follow up with converting
I realise this is a lot and very out-of-the-blue, so apologies in advance for all of the hassle. But please let me know if you'd be interested in proceeding, and maybe we can come up with a good plan!
Can you start by getting a PR submitted, even if it's a big one? I'd be glad to dive in and start reviewing and helping. We can actually hold off on other PRs and make this a priority to ease the integration pain.