Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raw_body must be used in parsing blob type #569

Merged
merged 1 commit into from
Mar 4, 2017
Merged

raw_body must be used in parsing blob type #569

merged 1 commit into from
Mar 4, 2017

Conversation

eagletmt
Copy link
Contributor

From rusoto v0.23.0, I've noticed that rusoto::s3::GetObjectOutput#output always returns Some("") even when other fields like e_tag is correct.
When payload shape is blob (e.g., s3:GetObject), response.raw_body must be used instead of response.body.

@eagletmt
Copy link
Contributor Author

It seems this issue was once fixed in #527, but re-introduced in #541 .

@mitsuhiko
Copy link
Contributor

Can confirm. Ran into the same issue just earlier.

@matthewkmayer matthewkmayer self-assigned this Mar 3, 2017
@matthewkmayer
Copy link
Member

👍 appears to work again!

@matthewkmayer matthewkmayer merged commit db74d84 into rusoto:master Mar 4, 2017
@matthewkmayer matthewkmayer mentioned this pull request Mar 4, 2017
Merged
@glasserc glasserc mentioned this pull request Mar 15, 2017
Closed
@eagletmt eagletmt deleted the fix-blob-parser branch March 25, 2017 09:13
@PSeitz PSeitz mentioned this pull request Mar 27, 2017
Closed
@eagletmt eagletmt mentioned this pull request Mar 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewkmayer matthewkmayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eagletmt @mitsuhiko @matthewkmayer