New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raw_body must be used in parsing blob type #569

Merged
merged 1 commit into from Mar 4, 2017

Conversation

Projects
None yet
3 participants
@eagletmt
Contributor

eagletmt commented Feb 24, 2017

From rusoto v0.23.0, I've noticed that rusoto::s3::GetObjectOutput#output always returns Some("") even when other fields like e_tag is correct.
When payload shape is blob (e.g., s3:GetObject), response.raw_body must be used instead of response.body.

@eagletmt

This comment has been minimized.

Show comment
Hide comment
@eagletmt

eagletmt Feb 24, 2017

Contributor

It seems this issue was once fixed in #527, but re-introduced in #541 .

Contributor

eagletmt commented Feb 24, 2017

It seems this issue was once fixed in #527, but re-introduced in #541 .

@mitsuhiko

This comment has been minimized.

Show comment
Hide comment
@mitsuhiko

mitsuhiko Feb 24, 2017

Can confirm. Ran into the same issue just earlier.

mitsuhiko commented Feb 24, 2017

Can confirm. Ran into the same issue just earlier.

@matthewkmayer matthewkmayer self-assigned this Mar 3, 2017

@matthewkmayer

This comment has been minimized.

Show comment
Hide comment
@matthewkmayer

matthewkmayer Mar 4, 2017

Member

👍 appears to work again!

Member

matthewkmayer commented Mar 4, 2017

👍 appears to work again!

@matthewkmayer matthewkmayer merged commit db74d84 into rusoto:master Mar 4, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

glasserc added a commit to glasserc/addon-shipping that referenced this pull request Mar 15, 2017

sign-xpi: Fetch a file from S3 and examine it
We need a git version of rusoto because no release yet includes
rusoto/rusoto#569.

@eagletmt eagletmt deleted the eagletmt:fix-blob-parser branch Mar 25, 2017

@PSeitz PSeitz referenced this pull request Mar 27, 2017

Closed

S3 File body always emtpy #590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment