New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only cargo-check integration tests on travis and appveyor #911

Merged
merged 1 commit into from Jan 7, 2018

Conversation

Projects
None yet
2 participants
@srijs
Member

srijs commented Jan 7, 2018

We've started to regularly run into the Travis time-outs again.

Since the integration tests are not being run, but only compiled (and then the compilation results discarded as the build exits), this PR changes the Travis and Appveyor tests to only cargo check the integration tests. This should shave some time off the builds.

I would advocate that for running integration tests in CI at a later point we use a separate pipeline (maybe use CircleCI or a custom Jenkins setup rather than chucking it on top of the existing ones), so we have a clean separation of concerns and keep the build times in check.

@srijs

This comment has been minimized.

Show comment
Hide comment
@srijs

srijs Jan 7, 2018

Member

The results are in, and we're shaving off a good 8-15 minutes per build with this.

Before:

screen shot 2018-01-07 at 1 32 17 pm

After (Rust beta on OS X ran into a time-out, my guess would be noisy neighbours, but a rerun would give us more clarity):

screen shot 2018-01-07 at 1 32 21 pm

Member

srijs commented Jan 7, 2018

The results are in, and we're shaving off a good 8-15 minutes per build with this.

Before:

screen shot 2018-01-07 at 1 32 17 pm

After (Rust beta on OS X ran into a time-out, my guess would be noisy neighbours, but a rerun would give us more clarity):

screen shot 2018-01-07 at 1 32 21 pm

@matthewkmayer

This comment has been minimized.

Show comment
Hide comment
@matthewkmayer

matthewkmayer Jan 7, 2018

Member

👍 thanks!

Member

matthewkmayer commented Jan 7, 2018

👍 thanks!

@matthewkmayer matthewkmayer merged commit 1c6cc11 into rusoto:master Jan 7, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment