Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teams, Users and Contacts resources (with golang modules) #33

Closed
wants to merge 11 commits into from

Conversation

Projects
None yet
1 participant
@nlamirault
Copy link

commented May 20, 2019

Hi,

This is a PR which use Golang modules instead of Dep.
New resources are :

  • resource pingdom_team
  • resource pingdom_user
  • resource pingdom_contact

README is updated, and i create an example directory.

$ make test
==> Checking that code complies with gofmt requirements...
go test -i $(go list ./... |grep -v 'vendor') || exit 1
echo $(go list ./... |grep -v 'vendor') | \
	xargs -t -n4 go test  -timeout=30s -parallel=4
go test -timeout=30s -parallel=4 github.com/russellcardullo/terraform-provider-pingdom github.com/russellcardullo/terraform-provider-pingdom/pingdom 
ok  	github.com/russellcardullo/terraform-provider-pingdom	(cached) [no tests to run]
ok  	github.com/russellcardullo/terraform-provider-pingdom/pingdom	(cached)

Team Import works (with teamid):

$ terraform import -var-file=vars.tfvars pingdom_team.test_one "402420"

nlamirault added some commits May 19, 2019

Update: vendoring using golang modules
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Add: example of the provider
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Add: scripts and Makefile from Terraform providers
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Add: Users, Teams and Contacts API
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Update: remove Gopkg files due to Golang modules migration
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Update: documentation
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Update: golang modules
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Update: Terraform's standard importer
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault

This comment has been minimized.

Copy link
Author

commented May 20, 2019

screencapture-my-pingdom-3-teams-2019-05-20-14_12_12
screencapture-my-pingdom-3-users-2019-05-20-14_12_20
screencapture-my-pingdom-3-users-edit-contact-14380685-2019-05-20-14_12_31

nlamirault added some commits May 20, 2019

Update: documentation
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Update: documentation
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

@nlamirault nlamirault closed this May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.