New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things to forward port from v1 to v2 #348

Open
rtfb opened this Issue Apr 13, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@rtfb
Copy link
Collaborator

rtfb commented Apr 13, 2017

A tracking issue to mark stuff that needs forward porting from v1 to v2.

API-breaking (i.e. must be addressed before releasing v2):

  • No known issues

Other:

  • Port v1 PR #334 to v2
  • Port v1 PR #352 to v2 - done in PR #509
  • Port v1 PR #366 to v2
@james-lawrence

This comment has been minimized.

Copy link

james-lawrence commented Nov 15, 2018

looks like this is done?

@dmitshur

This comment has been minimized.

Copy link
Collaborator

dmitshur commented Dec 23, 2018

This isn't done; those are three v1 PRs that need to be ported to v2. I'll work on porting #352 now. Edit: It is done now, see PR #509.

dmitshur added a commit that referenced this issue Dec 23, 2018

Document SanitizedAnchorName algorithm, copy implementation.
The goal of this change is to reduce number of non-standard library
packages (repositories) that blackfriday imports (not counting imports
used only for tests) from 1 to 0, and in turn, reduce the cost of
importing blackfriday into other projects.

Do so by documenting the algorithm of SanitizedAnchorName, and include
a copy of the small function inside blackfriday itself. The same
functionality continues to be available in the original location,
github.com/shurcooL/sanitized_anchor_name.Create. It can be used by
existing users and those that look for a small package, and don't need
all of blackfriday functionality. Existing users of blackfriday can use
the new SanitizedAnchorName function directly and avoid an extra
package import.

This change is a port of PR #352 from v1 into v2.

Updates #348.
Updates #350.

dmitshur added a commit that referenced this issue Jan 20, 2019

Document SanitizedAnchorName algorithm, copy implementation. (#509)
The goal of this change is to reduce number of non-standard library
packages (repositories) that blackfriday imports (not counting imports
used only for tests) from 1 to 0, and in turn, reduce the cost of
importing blackfriday into other projects.

Do so by documenting the algorithm of SanitizedAnchorName, and include
a copy of the small function inside blackfriday itself. The same
functionality continues to be available in the original location,
github.com/shurcooL/sanitized_anchor_name.Create. It can be used by
existing users and those that look for a small package, and don't need
all of blackfriday functionality. Existing users of blackfriday can use
the new SanitizedAnchorName function directly and avoid an extra
package import.

This change is a port of PR #352 from v1 into v2.

Updates #348.
Updates #350.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment