Relative URIs are considered safe #44

merged 2 commits into from Jan 8, 2014


None yet

3 participants

dcoxall commented Dec 9, 2013

A basic addition so relative URIs are considered safe when using HTML_SAFELINK. All the tests still passed but if I have missed something then let me know.

This fixes #26


Any chance you could add a test case to cover the change? I realize this is a pretty simple change that is unlikely to cause problems, but I would like to keep the test coverage as complete as possible. I don't think HTML_SAFELINK is tested at all right now.

dcoxall commented Dec 12, 2013

Yeah of course. I left out the test because I didn't spot anything already testing them but I'm happy to give it a shot.

dcoxall commented Dec 19, 2013

@russross I finally got round to adding some tests. Hope they are okay with you.

@rtfb rtfb merged commit 5405274 into russross:master Jan 8, 2014
@dcoxall dcoxall deleted the dcoxall:safe-relatives branch Jan 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment