New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block parsing for fenced code blocks in lists #476

Merged
merged 4 commits into from Aug 29, 2018

Conversation

Projects
None yet
6 participants
@tfogo
Contributor

tfogo commented Aug 22, 2018

This is the fix for #239 from @client9 and myself.

Sent a message in #239 outlining the issues client9 faced with the tests and the fixes I made.

@tfogo

This comment has been minimized.

Show comment
Hide comment
@tfogo

tfogo Aug 22, 2018

Contributor

cc @rtfb

Contributor

tfogo commented Aug 22, 2018

cc @rtfb

@mistyhacks

This comment has been minimized.

Show comment
Hide comment
@mistyhacks

mistyhacks Aug 23, 2018

+1 hope this gets in ASAP! Thanks @tfogo!

mistyhacks commented Aug 23, 2018

+1 hope this gets in ASAP! Thanks @tfogo!

@zacharysarah

This comment has been minimized.

Show comment
Hide comment
@zacharysarah

zacharysarah Aug 27, 2018

Thanks @tfogo! All the best for a quick approval! 🌟

zacharysarah commented Aug 27, 2018

Thanks @tfogo! All the best for a quick approval! 🌟

@rtfb

This comment has been minimized.

Show comment
Hide comment
@rtfb

rtfb Aug 29, 2018

Collaborator

LGTM, thanks a lot!

Collaborator

rtfb commented Aug 29, 2018

LGTM, thanks a lot!

@rtfb rtfb merged commit f1f45ab into russross:master Aug 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 8, 2018

Collaborator

I've just discovered this PR is causing #495.

Collaborator

dmitshur commented Oct 8, 2018

I've just discovered this PR is causing #495.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment