Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish VSCode extension to marketplace? #2013

Closed
jplatte opened this issue Oct 14, 2019 · 14 comments
Closed

Publish VSCode extension to marketplace? #2013

jplatte opened this issue Oct 14, 2019 · 14 comments

Comments

@jplatte
Copy link
Contributor

@jplatte jplatte commented Oct 14, 2019

Hi, is there a reason I have to clone the git repo and build everything from there instead of the way it works with RLS where I install the extension from inside VSCode and have the language server installed by the extension automatically?

@matklad

This comment has been minimized.

Copy link
Member

@matklad matklad commented Oct 14, 2019

Distributing pre-build binaries of the language server is tricky. RLS does this via rustup, but we are not at the stage where we are ready to be officially packaged.

@jplatte

This comment has been minimized.

Copy link
Contributor Author

@jplatte jplatte commented Oct 14, 2019

I'm not talking about pre-built binaries, I'm primarily talking about the VSCode extension. I haven't actually looked into how exactly the language server is installed. Would it not be viable to distribute it as a crate?

@matklad

This comment has been minimized.

Copy link
Member

@matklad matklad commented Oct 14, 2019

rust-analyzer contains git deps, so it can’t be published to crates.io. I think it should be possible to install it from git via cargo install, but that would make updating painfull (as everything would need to be rebuild from scratch). But yeah, perhaps it makes sense to distribute only the extension, to save one from needing npm to build...

@TheAifam5

This comment has been minimized.

Copy link

@TheAifam5 TheAifam5 commented Oct 14, 2019

Like the idea with only extension published to VSCode :D I'm on Arch and I use AUR package: https://aur.archlinux.org/packages/rust-analyzer-git/
without VSCode extension, because I have my multi-environment setup (for C, C++, JS/TS, Rust) and the other package will not work in my case.

@EliSnow

This comment has been minimized.

Copy link

@EliSnow EliSnow commented Oct 15, 2019

Could the extension be self contained as WASM?

@matklad

This comment has been minimized.

Copy link
Member

@matklad matklad commented Oct 15, 2019

@EliSnow

This comment has been minimized.

Copy link

@EliSnow EliSnow commented Nov 13, 2019

WASI, then 😉. With the push to have WASM everywhere it would be cool if the rust-analyzer core was a universal WASM which could run on any platform.

@bjorn3

This comment has been minimized.

Copy link
Contributor

@bjorn3 bjorn3 commented Nov 13, 2019

WASM is a bit slower than native. This is unfortunate for a language server, which needs to react very fast. Not sure if the difference is big enough to be noticable though.

@kanekv

This comment has been minimized.

Copy link

@kanekv kanekv commented Nov 14, 2019

@matklad If I build rust-analyzer binary myself - what should be done to manually install it? Is it enough for it just to be in the path?

@matklad

This comment has been minimized.

Copy link
Member

@matklad matklad commented Nov 14, 2019

@Lokathor

This comment has been minimized.

Copy link

@Lokathor Lokathor commented Dec 30, 2019

Another vote for "please at least put the vs code extension on the vs code marketplace".

@Extrawurst

This comment has been minimized.

Copy link

@Extrawurst Extrawurst commented Jan 27, 2020

This would be soooooo needed - the ergonomics of how to set this up manually in VSCode is really bad :(

edit: Actually I was wrong, my statement was based on an outdated instruction that changed since then and the install process now indeed is much easier being just a single command (as long as npm is installed and previous res extension removed from VSCode)

Thanks for all the great work. Using this project now makes the IDE experience MUCH better for rust! Sorry for the negative vibes @matklad

(still I believe for discoverability reasons alone having rust analyser the default if people search for rust support in the marketplace is gonna be a big deal)

@matklad

This comment has been minimized.

Copy link
Member

@matklad matklad commented Jan 28, 2020

I wouldn't call one-command installation "really bad". Significant effort were put into making the current installation process as easy as it is right now.

I understand that we can do better, but this takes effort.

I would advise against making +1 comments with (even slightly) negative emotional load, as they take everyone's time.

@lnicola

This comment has been minimized.

Copy link
Member

@lnicola lnicola commented Feb 12, 2020

@matklad we can probably close this now?

@matklad matklad closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.