Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path completion for reexport completes wrong name #3356

Closed
flodiebold opened this issue Feb 27, 2020 · 0 comments · Fixed by #3430
Closed

Path completion for reexport completes wrong name #3356

flodiebold opened this issue Feb 27, 2020 · 0 comments · Fixed by #3430
Labels
A-completion autocompletion

Comments

@flodiebold
Copy link
Member

  • add a dependency on glass_pumpkin = "0.3.3"
  • type glass_pumpkin::prime::from_; there's a suggestion for from_rng
  • accept the suggestion; suddenly it becomes gen_prime!

The problem here is that gen_prime is the original name of the function, but it's reexported from the prime module under a different name.
@flodiebold flodiebold added the A-completion autocompletion label Feb 28, 2020
flodiebold added a commit to flodiebold/rust-analyzer that referenced this issue Mar 3, 2020
@flodiebold
Fix completion snippet for reexported functions
3c78a95 
Fixes rust-lang#3356.
@flodiebold flodiebold mentioned this issue Mar 3, 2020
Merged
bors bot added a commit that referenced this issue Mar 3, 2020
@bors @flodiebold
Merge #3430
ce69561 
3430: Fix completion snippet for reexported functions r=matklad a=flodiebold

Fixes #3356.

Co-authored-by: Florian Diebold <flodiebold@gmail.com>
@bors bors bot closed this as completed in e55fc28 Mar 3, 2020
JoshMcguigan pushed a commit to JoshMcguigan/rust-analyzer that referenced this issue Apr 1, 2020
@flodiebold @JoshMcguigan
Fix completion snippet for reexported functions
9b1bcd9 
Fixes rust-lang#3356.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-completion autocompletion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix completion snippet for reexported functions flodiebold/rust-analyzer
1 participant
@flodiebold