Module alias misidentified as function declaration

[CleanCut]

With Cargo.toml:

[dependencies]
nalgebra-glm = { version = "0.6.0", features = ["serde-serialize"] }

In src/lib.rs:

pub use nalgebra_glm as glm;

glm is identified as a function declaration. It is a module alias, so it should be identified as a namespace, probably with some sort of alias modifier.

[matklad]

Good catch! I think this should be fixed in classify_name_ref function here:

https://github.com/rust-analyzer/rust-analyzer/blob/549ce9a9cf25efa3eba6549f96b2e43bc640faa9/crates/ra_ide_db/src/defs.rs#L105

[bnjjj]

It's a part where I didn't already dig in. I will give a try this week :)

[bnjjj]

I took a look at the code in

And it seems I should add to https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ra_ide_db/src/defs.rs#L121

this kind of pattern:

ast::Alias(it) => {
    let def = sema.to_def(&it)?;
    Some(Definition::ModuleDef(def.into()))
},

And then add ToDef implementation for use alias ?

[Veetaha]

Maybe duplicates #4030

[matklad]

I belive #4030 is different. There, we confuse namespaces, here, we don't handle aliases at all.

this kind of pattern:

I dont't think so, as there's there's no ModuleDef for an alias. Rather, the reference that is aliased should be resoled with sema.resolve_path

[CleanCut]

@matklad Did you mean to link to classify_name_ref? (You actually linked to classify_name)

https://github.com/rust-analyzer/rust-analyzer/blob/549ce9a9cf25efa3eba6549f96b2e43bc640faa9/crates/ra_ide_db/src/defs.rs#L198