New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline module to file refactoring #5054

Closed

theduke opened this issue Jun 25, 2020 · 2 comments

Labels

E-has-instructions E-medium

Contributor

theduke commented Jun 25, 2020

A code action that moves a top level inline module to it's own file would be very handy.

matklad added E-has-instructions E-medium labels

Member

matklad commented Jun 25, 2020

Some code pointers:

fix that creates a new module: https://github.com/rust-analyzer/rust-analyzer/blob/3615347fcebebaa58a5cbf675ae062aae149d9c3/crates/ra_ide/src/diagnostics.rs#L58-L70
there's no specific assists which feels similar, but, for example, add_function touches more than one file: https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ra_assists/src/handlers/add_function.rs

theduke mentioned this issue

Refactor AssistBuilder to manage a SourceChange #5245

Merged

Contributor Author

theduke commented Jan 15, 2021

This is implemented now.

theduke closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment