New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue: Fix remaining type mismatches in rust-analyzer repo #8961
Comments
Just a guess: Who is responsible for the |
The |
Aah, the |
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
10193: fix: fix type mismatches with `panic!()` on Rust 1.55.0 r=jonas-schievink a=jonas-schievink This addresses the regression mentioned in #8961 (comment) (no test because #10192 makes that rather hard, but I've checked that the analysis-stats are back to normal) bors r+ Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Update: For the other crates, it'd be interesting to check them again after the Chalk fix lands (especially Diesel). There are still some Chalk problems left that might occur there though. I would open new tracking issues for those once we're at 0 for rust-analyzer though. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
🎉 🥳 🎉
This is just amazing, would never have thought that being possible without effectively merging rustc and ra |
We've got about 1000 type mismatches remaining when running
rust-analyzer analysis-stats .
on the rust-analyzer repo itself. Since the repo actually typechecks, all of these type mismatches are actually bugs or missing features. Since we want to emit type errors sooner or later, we need to get these to 0 🙂Here's the categorization I've got so far: (all line numbers are from revision
b8262099cc51065259daf10b4b23ff49ce74434f
)Expected &dyn \w+Database
: Requires attribute macro support for salsa (Expand attribute-like proc macros #8971)Expected &HitCounter
: Caused by Inner item declared by nested macro not resolved #8930Expected .+, got !
: Investigate, this should easily work? Reproducible trivially:This only seems to happen with macros; e.g.
loop {}
does not result in a type mismatch.Fixed by #8983.
Expected .+, got <.+ as FnOnce.+>::Output
: Fixed by fix: Fix lowering of FnOnce() without return type #8987Probably also:
HasInterner::Interner
projection: ChalkHasInterner
derive macro doesn't work because it expands to named constant #9562Fold::Result
projection: probably also ChalkHasInterner
derive macro doesn't work because it expands to named constant #9562Expected InFile<&dyn AttrsOwner>, got InFile<&SourceFile>
: Improve expected type handling for calls #9560Also similar:
Expected &dyn X, got &impl X
: Handle implicitSized
bounds #8984Maybe also
These are the remaining ones I haven't categorized yet (28; I suspect a few are follow-ups from missing attribute macro support or other missing features):
The text was updated successfully, but these errors were encountered: