Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait support #909

Open
suhr opened this issue Feb 28, 2019 · 7 comments
Open

Trait support #909

suhr opened this issue Feb 28, 2019 · 7 comments

Comments

@suhr
Copy link

@suhr suhr commented Feb 28, 2019

Failed to exactly resolve the symbol. This is probably because rust_analyzer does not yet support glob imports or traits.

@kjeremy

This comment has been minimized.

Copy link
Contributor

@kjeremy kjeremy commented Feb 28, 2019

This is intentional. Can you give an example of where you are seeing this where you believe that it should work?

@suhr

This comment has been minimized.

Copy link
Author

@suhr suhr commented Feb 28, 2019

Even if it's intentional, it would be really nice to have a tracking issue, so people could know when this is implemented.

@DJMcNab

This comment has been minimized.

Copy link
Contributor

@DJMcNab DJMcNab commented Feb 28, 2019

We do support glob imports now I believe! Trait support however is quite far in the future.

bors bot added a commit that referenced this issue Feb 28, 2019
Merge #910
910: Update hover message since we do support globs r=matklad a=kjeremy

#909 drew attention to this.

Co-authored-by: kjeremy <kjeremy@gmail.com>
@suhr suhr changed the title Glob imports or traits support Trait support Mar 1, 2019
@colelawrence

This comment has been minimized.

Copy link

@colelawrence colelawrence commented Mar 26, 2019

What is the next step to moving this forward? Is this waiting on something else?
I've heard that this is related to the work we are doing with integrating chalk.

@colelawrence

This comment has been minimized.

@p-avital

This comment has been minimized.

Copy link

@p-avital p-avital commented Jun 6, 2019

@DJMcNab Any roadmap on trait support ? The document on Chalk RLS Integration is a bit opaque to me, any parts where some help is needed to enable trait support ? :)

@flodiebold

This comment has been minimized.

Copy link
Member

@flodiebold flodiebold commented Jun 6, 2019

@CptFox The foundations are there, and basic trait method completions are working. They're not working in all cases yet though, because a) there are still a bunch of missing features and b) there are some performance improvements needed.

I'm working on support for associated types right now, I'm making progress but haven't had that much time to invest in the last few weeks. It's hard to mentor further improvements to the Chalk integration before that's done, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.