internal: Refactor release workflow to reduce duplication #11029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
force-pushed
the
refactor-release
branch
from
4999d27
to
a0342ca
Compare
lnicola
changed the title
lnicola
force-pushed
the
refactor-release
branch
from
a0342ca
to
25e8f1a
Compare
lnicola
force-pushed
the
refactor-release
branch
from
25e8f1a
to
f694d7f
Compare
|
bors r+ I'll merge this now to give it time to bake in nightly, since everything is in flux anyway because if the GitHub change to MacOS 11. There are some binaries in my fork, and I'll address any review comments tomorrow (or we can revert it). |
|
Hmm, is building on MacOS 11 a breaking change for people still on 10.15? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces duplication by using
matrixand paves the way for #10483. Themuslbuilder is unchanged because it uses a container.We also get rid of the MacOS 11 SDK thing, which is from when most MacOS builders were on 10.Or not, the default is still 10.15.