fix: avoid adding enum parens in use path #12473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yue4u
commented
Jun 5, 2022
Comment on lines
+54
to
+61
| let should_add_parens = match completion.path_context() { | ||
| Some(PathCompletionCtx { has_call_parens: true, .. }) => false, | ||
| Some(PathCompletionCtx { kind: PathKind::Use | PathKind::Type { .. }, .. }) => { | ||
| cov_mark::hit!(no_parens_in_use_item); | ||
| false | ||
| } | ||
| _ => true, | ||
| }; |
There was a problem hiding this comment.
This is similar to
rust-analyzer/crates/ide-completion/src/render/function.rs
Lines 201 to 210 in 995a17f
has_call_parens: true to PathKind::Expr
Comment on lines
+91
to
+95
| // only show name in label if not adding parens | ||
| if !should_add_parens { | ||
| kind = StructKind::Unit; | ||
| } | ||
|
|
There was a problem hiding this comment.
It feels strange to me when completion labels still have parens
|
Thanks! |
|
📌 Commit 11693da has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12420