Use rustc_safe_intrinsic attribute to check for intrinsic safety
#13866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of maintaining a list that is poorly kept in sync we can just use the attribute.
rustbot
added
the
S-waiting-on-review
|
When was this attribute introduced in rust? If it's been there for a few stable releases then that's fine, we generally don't try to support toolchains older than ~3 releases |
|
It's rust-lang/rust#100719 which has only been merged about 4 months ago, so that's not that many stables yet. But since this touches intrinsics, people that are impacted by this will use nightly (or the beta bootstrap compiler in core/std itself, which is why I wanted to implement this in the first place). |
|
Ye, that seems fine to merge now then imo 👍 |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Dec 31, 2022
minor: remove unused known `Name`s After #13866, known `Name`s for safe intrinsics are no longer used and thus should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of maintaining a list that is poorly kept in sync we can just use the attribute.
This will make new RA versions unusable with old toolchains that don't have the attribute yet. Should we keep maintaining the list as a fallback or just don't care?