Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ide): highlight escapes in char #14512

Merged
merged 1 commit into from Apr 6, 2023
Merged

fix(ide): highlight escapes in char #14512

merged 1 commit into from Apr 6, 2023

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Apr 6, 2023

close #14489

before:

image

after:

image

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2023
@Veykril
Copy link
Member

Veykril commented Apr 6, 2023

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Apr 6, 2023

📌 Commit d4150f4 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 6, 2023

⌛ Testing commit d4150f4 with merge 72bb705...

bors added a commit that referenced this pull request Apr 6, 2023
@bors
Auto merge of #14512 - bvanjoi:fix-14489, r=Veykril
72bb705 
fix(ide): highlight escapes in char

close #14489

before:

![image](https://user-images.githubusercontent.com/30187863/230414343-16f34d31-e2a1-460b-b09f-f288b196c54e.png)

after:

![image](https://user-images.githubusercontent.com/30187863/230414581-b8c37355-6626-4745-9f2b-3d9d4f804b47.png)
@bors
Copy link
Collaborator

bors commented Apr 6, 2023

💔 Test failed - checks-actions

@Veykril
Copy link
Member

Veykril commented Apr 6, 2023

Looks like you need to run rustfmt on the code

@Veykril
Copy link
Member

Veykril commented Apr 6, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 6, 2023

📌 Commit f0c74b3 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 6, 2023

⌛ Testing commit f0c74b3 with merge de00bea...

bors added a commit that referenced this pull request Apr 6, 2023
@bors
Auto merge of #14512 - bvanjoi:fix-14489, r=Veykril
de00bea 
fix(ide): highlight escapes in char

close #14489

before:

![image](https://user-images.githubusercontent.com/30187863/230414343-16f34d31-e2a1-460b-b09f-f288b196c54e.png)

after:

![image](https://user-images.githubusercontent.com/30187863/230414581-b8c37355-6626-4745-9f2b-3d9d4f804b47.png)
@bors
Copy link
Collaborator

bors commented Apr 6, 2023

💔 Test failed - checks-actions

@Veykril
Copy link
Member

Veykril commented Apr 6, 2023

@bors retry

@bors
Copy link
Collaborator

bors commented Apr 6, 2023

⌛ Testing commit f0c74b3 with merge 3dd17bc...

@bors
Copy link
Collaborator

bors commented Apr 6, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 3dd17bc to master...

@bors bors merged commit 3dd17bc into rust-lang:master Apr 6, 2023
9 checks passed
@bvanjoi bvanjoi deleted the fix-14489 branch April 7, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

character escapes in char literals are not highlighted
4 participants
@bvanjoi @Veykril @bors @rustbot