Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer for loop variable #1501

Merged
merged 1 commit into from Jul 7, 2019

Conversation

@unrealhoang
Copy link
Contributor

commented Jul 7, 2019

My take on #1425

crates/ra_hir/src/ty/infer.rs Outdated Show resolved Hide resolved
@flodiebold
Copy link
Collaborator

left a comment

Looks good, just have one nit and a question for @matklad ;)

crates/ra_hir/src/ty/infer.rs Outdated Show resolved Hide resolved
crates/ra_hir/src/ty/infer.rs Outdated Show resolved Hide resolved
crates/ra_hir/src/ty/infer.rs Outdated Show resolved Hide resolved
crates/ra_hir/src/ty/infer.rs Outdated Show resolved Hide resolved

@unrealhoang unrealhoang force-pushed the unrealhoang:infer_for_loop branch from 2372ba1 to fcfe30c Jul 7, 2019

@unrealhoang unrealhoang force-pushed the unrealhoang:infer_for_loop branch from fcfe30c to f7cd40d Jul 7, 2019

@unrealhoang

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2019

Resolved all reviews.

@flodiebold

This comment has been minimized.

Copy link
Collaborator

commented Jul 7, 2019

bors r+

Thanks!

bors bot added a commit that referenced this pull request Jul 7, 2019

Merge #1501
1501: Infer for loop variable r=flodiebold a=unrealhoang

My take on #1425

Co-authored-by: Unreal Hoang <unrealhoang@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2019

@bors bors bot merged commit f7cd40d into rust-analyzer:master Jul 7, 2019

2 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@unrealhoang unrealhoang referenced this pull request Jul 8, 2019

bors bot added a commit that referenced this pull request Jul 9, 2019

Merge #1512
1512: Infer ? operator r=unrealhoang a=unrealhoang

Logical continuation of #1501

cc #1426

Co-authored-by: Unreal Hoang <unrealhoang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.