Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send old-style responsed to goto definition unless the client explicitelly opts in #1511

Merged
merged 3 commits into from Jul 8, 2019

Conversation

@matklad
Copy link
Collaborator

commented Jul 8, 2019

No description provided.

@kjeremy

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

I can't see why goto definition would be different in practice but to be correct spec-wise we should be checking declaration/implementation/type_definitition too.

With or without that though this LGTM.

@matklad

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

Yeah, that's true, I deliberately took a shortcut here: seems unlikely to matter in practice

@matklad

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 8, 2019

Merge #1511
1511: Send old-style responsed to goto definition unless the client explicitelly opts in r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

@bors bors bot merged commit e075e09 into master Jul 8, 2019

2 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bors bors bot deleted the conv branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.