Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer ? operator #1512

Merged
merged 3 commits into from Jul 9, 2019

Conversation

@unrealhoang
Copy link
Contributor

commented Jul 8, 2019

Logical continuation of #1501

cc #1426

@unrealhoang unrealhoang force-pushed the unrealhoang:infer_try branch from df64a15 to 283629f Jul 8, 2019

@unrealhoang unrealhoang force-pushed the unrealhoang:infer_try branch from 283629f to 944f71a Jul 8, 2019

crates/ra_hir/src/ty/tests.rs Outdated Show resolved Hide resolved

@unrealhoang unrealhoang force-pushed the unrealhoang:infer_try branch from a934c06 to 7bea70c Jul 8, 2019

@flodiebold
Copy link
Collaborator

left a comment

Looks good up to one tiny nit!

bors delegate+

crates/ra_hir/src/ty/tests.rs Outdated Show resolved Hide resolved
crates/ra_hir/src/ty/tests.rs Outdated Show resolved Hide resolved
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

✌️ unrealhoang can now approve this pull request

@unrealhoang unrealhoang force-pushed the unrealhoang:infer_try branch from 7bea70c to 9a0d4b1 Jul 9, 2019

@unrealhoang

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 9, 2019

Merge #1512
1512: Infer ? operator r=unrealhoang a=unrealhoang

Logical continuation of #1501

cc #1426

Co-authored-by: Unreal Hoang <unrealhoang@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@bors bors bot merged commit 9a0d4b1 into rust-analyzer:master Jul 9, 2019

2 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@unrealhoang unrealhoang deleted the unrealhoang:infer_try branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.