Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better completions for floating point primitive types #1514

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@marcogroppo
Copy link
Contributor

commented Jul 8, 2019

After #1499 completions for (some of) the inherent methods of f32 and f64 are now working.
Unfortunately during method resolution we were only looking for the f32 and f64 language items defined in libcore and we were ignoring the methods defined in libstd.

This PR fixes this issue.

@flodiebold

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Thanks!

bors r+

bors bot added a commit that referenced this pull request Jul 8, 2019

Merge #1514
1514: Better completions for floating point primitive types r=flodiebold a=marcogroppo

After #1499 completions for (some of) the inherent methods of `f32` and `f64` are now working.
Unfortunately during method resolution we were only looking for the `f32` and `f64` language items defined in `libcore` and we were ignoring the methods defined in `libstd`.

This PR fixes this issue.

Co-authored-by: Marco Groppo <marco.groppo@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

@bors bors bot merged commit 95d78a8 into rust-analyzer:master Jul 8, 2019

2 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@marcogroppo marcogroppo deleted the marcogroppo:float-runtime branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.