Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

underline mutable bindings #1550

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@matklad
Copy link
Collaborator

commented Jul 19, 2019

No description provided.

@matklad

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 19, 2019

bors r+
🤖

bors bot added a commit that referenced this pull request Jul 19, 2019

Merge #1550
1550: underline mutable bindings r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@lnicola

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

The answer is no, it doesn't work with rainbow idents 😄.

): [string, vscode.TextEditorDecorationType] => {
const color = new vscode.ThemeColor('ralsp.' + tag);
const decor = vscode.window.createTextEditorDecorationType({
color
color,
textDecoration,

This comment has been minimized.

Copy link
@lnicola

lnicola Jul 19, 2019

Contributor

Trailing comma makes prettier unhappy.

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@matklad matklad force-pushed the underline branch from b9c8dd2 to e418889 Jul 19, 2019

@matklad

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 19, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 19, 2019

Merge #1550
1550: underline mutable bindings r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@bors bors bot merged commit e418889 into master Jul 19, 2019

2 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bors bors bot deleted the underline branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.