Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd inlay parameter name hints for call expr #2843
Merged
Conversation
Signed-off-by: imtsuki <me@qjx.app>
This comment has been minimized.
This comment has been minimized.
|
Oops, I forgot to update the test snapshot. Now the CI should pass. |
Signed-off-by: imtsuki <me@qjx.app>
|
The implementation looks good to me! One day we should refactor |
Signed-off-by: imtsuki <me@qjx.app>
This comment has been minimized.
This comment has been minimized.
|
comment addressed |
This comment has been minimized.
This comment has been minimized.
|
bors r+ Thanks! |
bors bot
added a commit
that referenced
this pull request
Jan 15, 2020
2843: Add inlay parameter name hints for call expr r=matklad a=imtsuki This patch adds Intellij-like parameter name hints for literal values in function calls. <img width="624" alt="Screenshot" src="https://user-images.githubusercontent.com/8423594/72366533-68d7f800-3735-11ea-9279-cf193ca8ca2f.png"> Signed-off-by: imtsuki <me@qjx.app> Co-authored-by: imtsuki <me@qjx.app>
This comment has been minimized.
This comment has been minimized.
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
imtsuki commentedJan 14, 2020
This patch adds Intellij-like parameter name hints for literal values in function calls.
Signed-off-by: imtsuki me@qjx.app