Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chalk, and cache Chalk env elaboration through a query #4060

Merged
merged 1 commit into from Apr 20, 2020

Conversation

flodiebold
Copy link
Member

This should fix some of the worst performance problems.

This should fix some of the worst performance problems.
@flodiebold flodiebold requested a review from matklad April 20, 2020 17:28
@matklad
Copy link
Member

matklad commented Apr 20, 2020

bors r+

I wonder, in theory, which repository is responsible for maintaining the relevant benchmarks? I guess at the moment it's rust-analyzer, via analysis-stats, but I wonder if it makes sense to add some kind of benches to chalk? On the first blush, it seems like no, we need a fully integrated compiler to make meaningful perf measurements.

@flodiebold
Copy link
Member Author

There's an issue in the Chalk repo for creating benchmarks: rust-lang/chalk#398
I think it is possible to have meaningful benchmarks in the Chalk repo -- we can make Chalk files out of real-life cases.

@bors
Copy link
Contributor

bors bot commented Apr 20, 2020

@bors bors bot merged commit cd6d788 into rust-lang:master Apr 20, 2020
@flodiebold flodiebold deleted the chalk-up branch April 20, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants