Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of project-lock.json. #939

Merged
merged 4 commits into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@davidtwco
Copy link
Contributor

davidtwco commented Mar 5, 2019

Fixes #792.

This PR adds a initial implementation of project-lock.json, a build
system agnostic method of specifying the crate graph and roots.

@matklad
Copy link
Collaborator

matklad left a comment

This look great! Let's also document this feature somewhere? The docs are not organized too good at the moment, so just adding a section to the top-level README should work.

Show resolved Hide resolved crates/ra_project_model/src/lib.rs Outdated
Show resolved Hide resolved crates/ra_lsp_server/tests/heavy_tests/main.rs

davidtwco added some commits Mar 5, 2019

Initial implementation of project-lock.json.
This commit adds a initial implementation of project-lock.json, a build
system agnostic method of specifying the crate graph and roots.

@davidtwco davidtwco force-pushed the davidtwco:issue-792 branch from a3d8d83 to 3bc33ae Mar 7, 2019

@matklad
Copy link
Collaborator

matklad left a comment

r=me with an extra heavy test removed!

bors delegate+

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Mar 7, 2019

✌️ davidtwco can now approve this pull request

@davidtwco

This comment has been minimized.

Copy link
Contributor Author

davidtwco commented Mar 7, 2019

bors r+

bors bot added a commit that referenced this pull request Mar 7, 2019

Merge #939
939: Initial implementation of project-lock.json. r=davidtwco a=davidtwco

Fixes #792.

This PR adds a initial implementation of project-lock.json, a build
system agnostic method of specifying the crate graph and roots.

Co-authored-by: David Wood <david@davidtw.co>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Mar 7, 2019

@bors bors bot merged commit 4cd757c into rust-analyzer:master Mar 7, 2019

2 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidtwco davidtwco deleted the davidtwco:issue-792 branch Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.