Added some metadata for rust-analyzer package sufficient to build a package using cargo deb
#9631
Conversation
KOLANICH
changed the title
cargo debcargo deb
| @@ -1,7 +1,10 @@ | |||
| [package] | |||
| name = "rust-analyzer" | |||
| version = "0.0.0" | |||
| description = "TBD" | |||
| authors = ["rust-analyzer Team"] | |||
There was a problem hiding this comment.
This field has been optional since https://rust-lang.github.io/rfcs/3052-optional-authors-field.html.
The crates.io registry does not allow users to change the contents of already published versions: this is highly desirable to ensure working builds don't break in the future, but it also has the unfortunate side-effect of preventing people from updating the list of crate authors defined in Cargo.toml's package.authors field.
This is especially problematic when people change their name or want to remove their name from the Internet, and the crates.io team doesn't have any way to address that at the moment except for deleting the affected crates or versions altogether. We don't do that lightly, but there were a few cases where we were forced to do so.
The contents of the field also tend to scale poorly as the size of a project grows, with projects either making the field useless by just stating "The $PROJECT developers" or only naming the original authors without mentioning other major contributors.
It was removed in #9493.
There was a problem hiding this comment.
I think it's ok to leave this in, if cargo-deb needs this. Although would be a good idea to patch cargo-deb to not require it either!
There was a problem hiding this comment.
Yeah, we should at least file an issue. Do you know why it fails without the filed? cargo-deb doesn't seem to use cargo-metadata.
There was a problem hiding this comment.
Ah, cargo-deb can also use [package.metadata.deb], but I'm not sure that's better.
|
Looks good to me! |
KOLANICH
force-pushed
the
metadata
branch
2 times, most recently
from
e49799c
to
b23530f
Compare
…using `cargo deb` Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
|
bors r+ |
No description provided.