Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: public fn alignment::sparse::expand_kmer_matches not documented #494

Open
corneliusroemer opened this issue Jul 29, 2022 · 0 comments · May be fixed by #507
Open

DOC: public fn alignment::sparse::expand_kmer_matches not documented #494

corneliusroemer opened this issue Jul 29, 2022 · 0 comments · May be fixed by #507

Comments

@corneliusroemer
Copy link
Contributor

The following public function lacks a doc string:

pub fn expand_kmer_matches(

Some important questions to answer:

  • exact meaning of allowed_mismatches, if I read the code correctly, extension happens independently on either side of the k-mer match, and stops after allowed_mismatches in each direction. So if you specify allowed_mismatches = 1 the extended match will actually contain 2 mismatches, one on either side - which is not what one may expect at all.
  • whether output matches can overlap or not, if they don't overlap, will adjoining matches be merged or just border directly side-by-side?
@Ptipiak Ptipiak linked a pull request Nov 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant