Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Baum-Welch algorithm for Discrete HMM #432

Merged
merged 3 commits into from Jul 6, 2021

Conversation

rodtheo
Copy link
Contributor

@rodtheo rodtheo commented May 30, 2021

Some improvements related to Hidden-Markov Model Module:
* Implementation of Baum-Welch algorithm for Discrete HMM;
* Creation of a trainable Discrete Emission Module with implicit end state;
* Add tests for Baum-Welch algorithm.

Improve Hidden-Markov Models Module:

    * Implementation of Baum-Welch algorithm for Discrete HMM

    * Creation of a Discrete Emission Module with implicity end state

    * Add example usage of baum-welch

    * Add tests for baum-welch and HMM discrete with end state
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, thank you!

@johanneskoester
Copy link
Contributor

Can you please format with cargo fmt?

@rodtheo
Copy link
Contributor Author

rodtheo commented Jun 25, 2021

For sure! The code is now formatted. By the way, thanks for the review! I look forward to contributing more to this awesome crate.

@johanneskoester johanneskoester changed the title Baum-Welch algorithm for Discrete HMM feat: Baum-Welch algorithm for Discrete HMM Jul 6, 2021
@johanneskoester johanneskoester merged commit eb8b8cb into rust-bio:master Jul 6, 2021
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants