/ rust-bio Public
fix: Make QGramIndex use less memory; add docs; fix bug #471
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
I've added some more documentation and clarifying tests to
so that the implementation is more clear without looking at the code.
I found one small bug: q-grams of value
AAA) wouldn't be
max_count. I've added a test that would fail if the
.skip(1)was still there.
The size of the
posvector was always
|text|, but it's sufficient to
only allocate memory for the number of unfiltered q-grams. Please verify
this. I've added a
pattern="AAA"test that should show
that things are still working.