Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added code to ignore commented lines in a bed file #474

Merged
merged 4 commits into from Jan 12, 2022

Conversation

mrvollger
Copy link
Contributor

Added code to ignore commented lines in a bed file and also added a simple test function. I think this resolves #473.

@dcroote dcroote changed the title Added code to ignore commented lines in a bed file fix: added code to ignore commented lines in a bed file Jan 10, 2022
@coveralls
Copy link

coveralls commented Jan 10, 2022

Coverage Status

Coverage increased (+0.02%) to 88.692% when pulling cb83123 on mrvollger:master into 9e8a7ca on rust-bio:master.

Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for including the test.

@mrvollger
Copy link
Contributor Author

mrvollger commented Jan 11, 2022

Great, thanks for taking a look! Anything else that needs to be done before it can be merged?

@dcroote dcroote requested a review from a team January 11, 2022 19:13
@mbhall88
Copy link
Member

Last thing before merging: could you please add an entry in the changelog?

@mrvollger
Copy link
Contributor Author

Hi @mbhall88 I added a line the the changelog but it is my first time contributing so I hope I am following the right conventions here.

Copy link
Member

@mbhall88 mbhall88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that. Just one suggestion to change it to unreleased as I'm not sure whether this change will constitute a patch or minor version bump. And this way it is easier to see what has changed on the repo since the last release

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Michael Hall <michael@mbh.sh>
@mrvollger
Copy link
Contributor Author

Thanks, that is a useful way to link that I didn't know about. Thanks!

@dcroote dcroote merged commit d17f823 into rust-bio:master Jan 12, 2022
10 checks passed
@dcroote
Copy link
Contributor

dcroote commented Jan 12, 2022

Thanks @mrvollger. @mbhall88 - because "fix:" corresponds to a Semver patch - the now pending release is for 0.39.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bed::Reader does not respect comment lines
4 participants