Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: base specific hop parameters in homopoly-pair-hmm #480

Merged
merged 2 commits into from Feb 23, 2022

Conversation

tedil
Copy link
Contributor

@tedil tedil commented Feb 23, 2022

build_transition_table now expects something that implements the trait BaseSpecificHopParameters instead of HopParameters, since the latter can be expressed as the first (i.e. there's a default impl of BaseSpecificHopParameters for anything that implements HopParameters which just uses the base-agnostic homopolymer run start / extend probabilities)

@johanneskoester johanneskoester changed the title Base specific homopoly-pair-hmm feat!: base specific hop parameters in homopoly-pair-hmm Feb 23, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 88.764% when pulling 1b09989 on tedil:base-specific-hphmm into 8a900a2 on rust-bio:master.

@johanneskoester johanneskoester merged commit cf75b6c into rust-bio:master Feb 23, 2022
9 of 11 checks passed
This was referenced Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants