/ rust-bio Public
feat: add standard derives to all public types #505
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Implement Rust API Guidelines
In working with Rust bio, I needed to fork the project in order to serialize some public types like
Orf. Missing derive implementations is a common problem I seem to encounter when working with many crates, so I took the afternoon to add every recommended trait (
#[derive(Default, Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Hash, Debug, Serialize, Deserialize)]) to every
pub enumin the crate using a script, then I sat down to sort out the compiler issues.
If derives failed because a private
rust-biotype didn't implement a certain trait, then derives for those traits were added to private types until they compiled. For derives failing because types outside of
rust-biodon't implement a trait, those derives were removed until the code compiled.
After adding all of those derives, I also cleaned up a few clippy lints in the second commit. Adding some of those
Copyderives meant a lot of calls to
Clonecould be removed!
Sorry this looks like a massive change! Should be relatively trivial to review though, since it should only be adding derives and not touching anything more complex.