/ rust-bio Public
perf: mark dna::complement as inline #510
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
This speeds up computing the complement on a long string by ~2.3x. Not sure why rust doesn't inline such a trivial function on its own.
I didn't manage to compile your benchmarks, hence I can only point to the results from my own project.
There is still a small overhead of Rust over C. I think Rust repeatedly checks that
a as usizeis a valid index in
COMPLEMENT. While that is usually not a problem, it is here, because the loop is so small and the extra instructions clog the pipeline.