Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash_newtype macro #59

Merged
merged 4 commits into from Aug 15, 2019

Conversation

@stevenroose
Copy link
Collaborator

commented Aug 13, 2019

Adds a publicly exported macro that allows for easily creating newtypes around bitcoin_hashes hash types.

This helps with rust-bitcoin/rust-bitcoin#284.

@apoelstra

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Can you add a minor version bump (and CHANGELOG.md entry) to this PR?

Show resolved Hide resolved src/serde_macros.rs Outdated
Show resolved Hide resolved src/serde_macros.rs Outdated
@stevenroose

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 14, 2019

Can you add a minor version bump (and CHANGELOG.md entry) to this PR?

Done.

stevenroose added some commits Aug 15, 2019

Optimize serde_impl
Allow for usage with types that are not byte array newtypes.

@stevenroose stevenroose force-pushed the stevenroose:hash-newtype branch from 1f78a53 to f8ded91 Aug 15, 2019

@apoelstra
Copy link
Member

left a comment

Looks good!

@apoelstra apoelstra merged commit bf05606 into rust-bitcoin:master Aug 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.