Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hex path in serde macros relative to the crate #71

Merged
merged 2 commits into from Jan 14, 2020

Conversation

@elichai
Copy link
Collaborator

elichai commented Jan 8, 2020

Currently the serde macros (use in creating new hash types) did:
use hex::ToHex;
which works fine in this library but not anywhere else.
the only reason it works in rust-bitcoin is because it actually used the hex crate(https://docs.rs/hex/0.4.0/hex/trait.ToHex.html) without anyone noticing (which was left in non-test code by accident)

so now it should use the correct hex traits.

elichai added 2 commits Jan 8, 2020
@elichai elichai mentioned this pull request Jan 8, 2020
@elichai

This comment has been minimized.

Copy link
Collaborator Author

elichai commented Jan 9, 2020

The only test that fails is the Emscripten one, I'll try to fix it but it's unrelated to this PR.

Copy link
Collaborator

stevenroose left a comment

LGTM. Looks like we need a publish after this is merged, @apoelstra

Copy link
Contributor

dr-orlovsky left a comment

Yeah, I had to fix this along the rest when was working on hash types for rust-bitcoin, but missed this. LGTM in this way.

@apoelstra apoelstra merged commit 2961c22 into rust-bitcoin:master Jan 14, 2020
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.