`signrawtransactionwithkey` has no type or model with the same name

[jamillambert]

The RPC signrawtransactionwithkey replaced signrawtransaction in v18 and above. It still uses the same Type name of SignRawTransaction which causes an issue with verify and when manually searching the code for the type or model.

I would suggest renaming it everwhere to SignRawTransactionWithKey, similarly with the test and macro name. And keeping a duplicate of the v17 ones with the current name, it's the only version that has both RPCs

EDIT: I fixed verify and there is no issue with this RPC since it only checks the line in verify vs the types table, but I still prefer the solution above to how it is now.

[tcharding]

SGTM, I was bitten by this one before.

[jamillambert]

This is a little more complicated than described above.

There is also signrawtransactionwithwallet in wallet that has no struct in types nor its own model. It's tested by using its own client macro and the same SignRawTransaction type from raw_transactions in a test in tests/raw_transactions.rs.

There are possibly other cases of this, but I couldn't find any.

Maybe just alias the types so that if you just assume the RPC is the same format as the others it still works?

pub type SignRawTransactionWithKey = SignRawTransaction;
pub type SignRawTransactionWithWallet = SignRawTransaction;

[tcharding]

This time I looked at the code. I agree with adding alias'. We could mention on the docs something like

"our stated policy is that for every method 'somecoremethod' there exists a return type SomeCoreMethod however the return for this method is the same as signrawtransaction and the methods are reasonably related so we just alias"

(just typed out quickly)