Unify the into_model style in integration tests
#349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a variation in the way `into_model()` is used, e.g. `unwrap()` vs `expect()`, `using let _ =` or not, explicit error typing. Make all occurrences in integration_test the same.
There is a variation in placing the version feature gate above or below the test attribute. Change them all to be consistent.
jamillambert
force-pushed
the
0904-test-syntax
branch
2 times, most recently
from
9bddc31 to
4fcbef1
Compare
jamillambert
changed the title
into_model style in integration tests
tcharding
approved these changes
Sep 5, 2025
Member
|
Nice! Re-export fixes prove this was worth doing. |
Member
|
Patch 2 is right out of my play book, I f***ing love it. |
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
…ation tests
4fcbef1da2d7da13bd7d019f218f5240bb99b9ee Unify test version feature gate placement (Jamil Lambert, PhD)
eeb4f3088ff7ae5adea4debc8e843b290348e2d8 Unify integration_test into_model() calls (Jamil Lambert, PhD)
Pull request description:
#348 describes the problem.
- There is a variation in the way `into_model()` is used, e.g. `unwrap()` vs `expect()`, `using let _ =` or not, explicit error typing. Make all occurrences in `integration_test` the same. Explicitly state the error type, this required some new imports in the test files and exports in types.
- `NumericError` exported in types v17 and reexported up to v29.
- `WalletProcessPsbtError` exported in v26 and reexported up to v29.
- There is a variation in placing the version feature gate above or below the test attribute. Change them all to be consistent.
ACKs for top commit:
tcharding:
ACK 4fcbef1da2d7da13bd7d019f218f5240bb99b9ee
Tree-SHA512: 6d91614c7f01fecfcba87a8c9481fbbdc62c64edeedfd394115845e9360d15bdae117f9335d952178a7fbc21d0a49e51aaf8920a16d1f711322a702df755ef09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#348 describes the problem.
into_model()is used, e.g.unwrap()vsexpect(),using let _ =or not, explicit error typing. Make all occurrences inintegration_testthe same. Explicitly state the error type, this required some new imports in the test files and exports in types.NumericErrorexported in types v17 and reexported up to v29.WalletProcessPsbtErrorexported in v26 and reexported up to v29.