Fix GetRawMempoolVerbose client macro and test
#395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getrawmempool and verbose types were not updated for changes in the inner MempoolEntry type between v18 and v23. Add the types and into_model implementations for these versions.
The client macro for getrawmempool has two associated types. The client macro for the verbose type was set to return the non verbose type. Change the return type for the macro to GetRawMempoolVerbose.
Uncomment the section of the test for the verbose type now that it has been fixed.
tcharding
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client macro for
getrawmempoolwith verbose set to true returns the non verbose type. The test for this case was commented out.The inner type
MempoolEntrychanged multiple times from v18-v23, butGetRawMempoolVerbosestill used the v17 type until v24. For v24 and up the correctMempoolEntrytype version is used.getrawmempooltypes andinto_modelfunctions or reexports of the correct version for v18-v23 that use the updatedMempoolEntrytypes.Closes #389