Skip to content

Conversation

@AaronDewes
Copy link
Contributor

This is just simple dependency update to avoid people having duplicate (old) versions of base64 in their dependency tree if they use this crate.

@apoelstra
Copy link
Member

I think this is fine, but can you update the included lockfiles Cargo-minimal.lock and Cargo-recent.lock?

You can run just update-lock-files to do this.

@tcharding
Copy link
Member

Verified that this is the same version we depend on in bitcoin.

This is just simple dependency update to avoid people having duplicate (old) versions of base64 in their dependency tree if they use this crate
@tcharding
Copy link
Member

I rebase on master, updated the lock files, and force pushed to your branch. Hope you don't mind. You can use git range-diff aeaf57c...@ to see what changes I pushed and you can verify aeaf57c is your patch by looking at the original push above. You are still the patch author, and I don't know where github gets the data to include my avatar on the patch.

Thanks for the PR!! Appreciate it.

@tcharding tcharding merged commit 423859e into rust-bitcoin:master Mar 6, 2025
@AaronDewes AaronDewes deleted the bump-base64 branch March 7, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants